Update yarn to 1.16.0 #29503
Merged
Update yarn to 1.16.0 #29503
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Sorry I missed this PR earlier, Josh. I would suggest updating the docs here to use Lines 13 to 20 in e654149 or alternately pointing people to SETUP.md if you don't want duplication. |
Also removes the explict `npm rebuild node-sass` because it's now part of post-install.
uponthesun
reviewed
Jul 8, 2019
|
The parts I commented on look good! |
uponthesun
approved these changes
Jul 10, 2019
| && echo "ALTER USER 'root'@'localhost' IDENTIFIED WITH mysql_native_password BY '';" | mysql \ | ||
| && chown -R mysql:mysql /var/lib/mysql /var/run/mysqld \ |
There was a problem hiding this comment.
Nitpick: I don't think you need to run the same chown command twice since the changes to the directories will persist from the first time.
There was a problem hiding this comment.
I tried without first, but I was getting a hang on shutdown. Any idea why that would be?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Patterned after PR #22093. Replaces PR #29495.
I will send mail separately asking folks to upgrade their local install of yarn.