Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Droplet with node version 8.15.0. #29577

Merged
merged 1 commit into from Jul 10, 2019
Merged

Droplet with node version 8.15.0. #29577

merged 1 commit into from Jul 10, 2019

Conversation

jmkulwik
Copy link
Contributor

@jmkulwik jmkulwik commented Jul 9, 2019

This is droplet minified files created with node version 8.15.0 (see droplet-editor/droplet#208 for the change in the droplet repo). The diff of droplet-full.js is mostly the reordering of two large sections of code. If I manually remove those two sections of code (which I have verified as identical), the diff boils down to this:

image
image

Copy link
Member

@davidsbailey davidsbailey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@jmkulwik jmkulwik merged commit 82be808 into staging Jul 10, 2019
@jmkulwik jmkulwik deleted the use-new-droplet-version branch August 9, 2019 23:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants