Minor tweaks to right side header spacing #29622
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tween the sign in/project buttons on Pegasus.
Erin007
approved these changes
Jul 11, 2019
|
I will just reiterate my concern that the left-margin and right-margin are no longer the same. |
|
@breville Mark says: "when we were mocking it up it looked fine, even though there wasn't perfect symmetrical spacing on left and right" |
|
Also, ran it past Marina and she's okay with it |
|
Not strongly enough to say no :) But I do notice this on some sites and apps when it doesn't match. |
breville
approved these changes
Jul 11, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jira task and spec
Minor tweaks to the header. The general gist is that we're shifting the right header stuff slightly to the right and putting a bit more space between each element.
Header for production dashboard, dashboard with change, production pegasus, pegasus with change:
Dashboard and pegasus with the change. They're the same! 😄
