Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

I18n sync In & Up 07/15 #29706

Merged
merged 5 commits into from Jul 16, 2019
Merged

I18n sync In & Up 07/15 #29706

merged 5 commits into from Jul 16, 2019

Conversation

deploy-code-org
Copy link
Contributor

No description provided.

@bethanyaconnor bethanyaconnor self-assigned this Jul 15, 2019
Hamms
Hamms approved these changes Jul 15, 2019
View reviewed changes
Copy link
Contributor

@Hamms Hamms left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I assume the significant amount of course_content changes are a product of the oldest_active_level change? If so, LGTM!

@bethanyaconnor
Copy link
Contributor

Yep! There was a change to csd3-2019 that was separate but otherwise all the level changes are due to active levels.

1da7214 is the commit that updates the source files based on active levels. The other commits are unrelated to active levels.

@Hamms
Copy link
Contributor

Hamms commented Jul 15, 2019

Nice!

@bethanyaconnor bethanyaconnor merged commit d1df955 into staging Jul 16, 2019
@bethanyaconnor bethanyaconnor deleted the i18n-sync-in-up-07-15 branch July 18, 2019 17:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Hamms Hamms Hamms approved these changes

@nkiruka nkiruka nkiruka approved these changes

Assignees

@bethanyaconnor bethanyaconnor

Labels
i18n
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@deploy-code-org @bethanyaconnor @Hamms @nkiruka