Feedback: pass real data to the AllFeedback component and determine seenByStudent #29724
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Spec: notifying students about teacher feedback
Continuation of #29530
Now that
script_level_idis being saved for new TeacherFeedbacks, I populated the All Feedback page with real data.seenByStudentwill be set totrueifstudent_first_visited_atorseen_on_feedback_page_atis not null as outlined in #29623.If the
script_level_idis not yet set theLevelFeedbackEntrystill renders with the comment text but the details about the lesson and unit are blank, for now.