Add SpriteLab entrypoint #29831
Merged
Add SpriteLab entrypoint #29831
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 5859ba6.
jmkulwik
reviewed
Jul 22, 2019
| @@ -17,10 +17,7 @@ export var checkForUnsupportedBrowsersOnLoad = function() { | |||
| if (isMobileDevice()) { | |||
| if (appOptions.app === 'applab') { | |||
| textDivId = '#applab-unsupported-tablet'; | |||
| } else if ( | |||
| appOptions.app === 'gamelab' && | |||
| !appOptions.valueTypeTabShapeMap | |||
There was a problem hiding this comment.
What was the reason for removing this?
There was a problem hiding this comment.
The goal here was to show the warning for gamelab but not spritelab (valueTypeTabeShapeMap is only set for spritelab). Now that spritelab is its own app type, though, this check can just be appOptions.app === 'gamelab'
There was a problem hiding this comment.
ugh... valueTypeTabShapeMap identifying spritelab.
Thanks for catching that!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Third attempt at creating this entrypoint (#29550 was reverted by #29707, then #29731 was reverted by #29790)
This PR addresses the issue with #29731 by adding a case for
appOptions.app === 'spritelab'in all of the places we checkappOptions.app === 'gamelab'. As future work, we'd like to get rid of these hard-coded app type checks at some point.