Update droplet dropdowns to extend outside the coding workspace (reintroduces reverted PR) #29849
Conversation
jmkulwik
changed the title
| @@ -84,7 +84,7 @@ class CodeWorkspace extends React.Component { | |||
| if (textbox.style.bottom) { | |||
| $(textbox).animate( | |||
| {bottom: debuggerHeight}, | |||
| {step: utils.fireResizeEvent} | |||
| {done: utils.fireResizeEvent} | |||
There was a problem hiding this comment.
Fixes a long-standing issue where the code workspace would resize to the wrong size. This is especially apparent on computers that are close to their maximum ram when running applab. This was fixed as part of this PR because the droplet changes exacerbated the issue. I checked with @ryansloan, and he agrees that the new UI is preferred.
OLD
NEW
| @@ -44,13 +44,17 @@ | |||
| opacity: 1; | |||
| } | |||
|
|
|||
| // When opening the debug console with the ellipsis, the codeTextbox sometimes | |||
| // renders over the debug console. Setting the z-index to 2 is a work-around for | |||
| // this issue. See JsDebugger.jsx. | |||
There was a problem hiding this comment.
There was a problem hiding this comment.
Thanks for capturing this issue. Even though it is harder, I think we should do the 'hard' solution that you propose in that ticket.
There was a problem hiding this comment.
I agree. The "easy" option might just be a stop-gap while we work on the "hard" option.
| @@ -98,8 +98,7 @@ const styles = { | |||
| borderLeftStyle: 'none', | |||
| borderTopWidth: 1, | |||
| borderTopStyle: 'solid', | |||
| borderTopColor: '#ddd', | |||
| overflow: 'hidden' | |||
There was a problem hiding this comment.
My only concern here is unexpected side effects with Blockly. I assume you have already verified that droplet is ok with this change. If you've tested various Blockly levels as well, I'm ok.
There was a problem hiding this comment.
Thanks for noting that. I went ahead and spot-checked a couple blockly levels, and they look good.
Reintroduce this PR: #29588 which was reverted because the app display was being cut off along the edges. See https://eyes.applitools.com/app/test-results/00000251838817645025/?accountId=mG4DoRfv0ntEgI3XIYBulrKxlZqrHtGwbP3V103ojvLFU110 for details.
In the past, droplet dropdowns were cut off when they left the app workspace. Now, dropdowns are visible outside the workspace.
Relates to this PR in the droplet repo: droplet-editor/droplet#211
OLD:
NEW:
