Don't exit container if bash is running [skip ui] #29871
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
uponthesun
changed the title
uponthesun
changed the title
davidsbailey
approved these changes
Jul 31, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this change, if you "ssh" into the drone container (i.e. ssh onto the instance and bash into the container), the container will stay alive until you exit bash. This makes it easier to debug tests without having to worry about the test finishing and losing everything.
One issue: if you close your ssh session without exiting bash, the bash process within the container will still be alive. (For example, if you closed your laptop.) Root cause (I think) - terminating the session kills the
docker execprocess on the host, but that doesn't kill the bash process in the container: moby/moby#9098We may be okay with this, given that it will eventually hit the 3-hour timeout we have configured on our drone repository settings, and that sshing in isn't super common.