Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add about.md and csf-transition-guide.md translations #29940

Merged
merged 4 commits into from Jul 26, 2019

Conversation

bethanyaconnor
Copy link
Contributor

No description provided.

@Hamms
Copy link
Contributor

Hamms commented Jul 25, 2019

Hmm, looks like the new files got downloaded as about.md.es-MX.partial instead of as about.es-MX.md.partial as I would have expected. Have you been able to verify whether or not that actually works?

@bethanyaconnor
Copy link
Contributor Author

bethanyaconnor commented Jul 25, 2019

You're right, the international/about pages don't work (they just render in English). The translations render if I change the suffix to <locale>.md.partial though.

@bethanyaconnor bethanyaconnor self-assigned this Jul 25, 2019
@Hamms
Copy link
Contributor

Hamms commented Jul 25, 2019

Yeah, that's what I figured. Go ahead and change the files in this PR; I'll update

"translation": "/i18n/%original_path%/%file_name%.%locale%.%file_extension%",
to produce the right naming scheme for the next sync

@bethanyaconnor bethanyaconnor merged commit b38a407 into staging Jul 26, 2019
@bethanyaconnor bethanyaconnor deleted the commit-about-translations branch March 17, 2022 15:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants