Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

convert some HOC download strings to markdown so we can render them safely #29962

Merged
merged 3 commits into from Aug 2, 2019
Merged

convert some HOC download strings to markdown so we can render them safely #29962

merged 3 commits into from Aug 2, 2019

Conversation

Hamms
Copy link
Contributor

@Hamms Hamms commented Jul 26, 2019

No description provided.

@codecov-io
Copy link

codecov-io commented Jul 26, 2019 •
edited

Codecov Report

❗ No coverage uploaded for pull request base (staging@cfc7860). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             staging   #29962   +/-   ##
==========================================
  Coverage           ?   76.48%           
==========================================
  Files              ?      681           
  Lines              ?    27667           
  Branches           ?        0           
==========================================
  Hits               ?    21162           
  Misses             ?     6505           
  Partials           ?        0

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cfc7860...b9f1f0b. Read the comment docs.

@Hamms Hamms marked this pull request as ready for review August 2, 2019 20:26
@Hamms Hamms requested a review from islemaster August 2, 2019 20:26
@Hamms @islemaster
typo fix
b9f1f0b 
Co-Authored-By: Brad Buchanan <brad@code.org>
@Hamms Hamms merged commit 92de2f8 into staging Aug 2, 2019
@Hamms Hamms deleted the sanitize-hoc-download-strings branch August 2, 2019 23:42
@joshlory
Copy link
Contributor

joshlory commented Aug 9, 2019

Possible regression from this change: https://codedotorg.slack.com/archives/CFTFD6BPV/p1565136039092900

image

@Hamms
Copy link
Contributor Author

Hamms commented Aug 9, 2019

ahhh, the problem is that those are invalid urls. I'll fix

@Hamms Hamms mentioned this pull request Aug 9, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@islemaster islemaster islemaster approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@Hamms @codecov-io @joshlory @islemaster