Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sound dialog height #29970

Merged
merged 3 commits into from Jul 26, 2019
Merged

Sound dialog height #29970

merged 3 commits into from Jul 26, 2019

Conversation

larrypo
Copy link
Contributor

@larrypo larrypo commented Jul 26, 2019

Creating a new pull request that should be from code-dot-org/code-dot-org instead of from larrypo/code-dot-org.

Copy link
Contributor

@islemaster islemaster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@codecov-io
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (staging@1875fff). Click here to learn what that means.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##             staging   #29970   +/-   ##
==========================================
  Coverage           ?   72.03%           
==========================================
  Files              ?     1367           
  Lines              ?    84446           
  Branches           ?     3397           
==========================================
  Hits               ?    60828           
  Misses             ?    20385           
  Partials           ?     3233
Flag Coverage Δ
#integration 55.07% <100%> (?)
#storybook 56.61% <100%> (?)
#unit 58.13% <100%> (?)
Impacted Files Coverage Δ
apps/src/code-studio/components/SoundLibrary.jsx 80.39% <ø> (ø)
apps/src/code-studio/components/SoundList.jsx 79.41% <100%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1875fff...3e83593. Read the comment docs.

@larrypo larrypo merged commit 889ed52 into staging Jul 26, 2019
@fisher-alice fisher-alice deleted the sound_dialog_height branch July 13, 2022 22:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants