Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pin our JS Google maps API at version 3.37 (the current version). #29983

Merged
merged 2 commits into from Sep 9, 2019

Conversation

bethanyaconnor
Copy link
Contributor

@bethanyaconnor bethanyaconnor commented Jul 26, 2019

The release notes for version 3.7 were last updated in 2012. v3.37 is also the last version that supports Fusion Tables. My understanding is that we will be auto-upgraded to v3.38 in November but it's safer to pin to this version and remove this when we're fully off Fusion Tables.

@bethanyaconnor bethanyaconnor marked this pull request as ready for review September 9, 2019 19:17
@breville
Copy link
Member

breville commented Sep 9, 2019

Good call!

There's enough duplication here that it kind of feels like we might ideally want something in a global configuration, but for now this seems like a fine lockdown.

@bethanyaconnor bethanyaconnor merged commit 33db02f into staging Sep 9, 2019
@bethanyaconnor bethanyaconnor deleted the pin-gmap-version branch September 9, 2019 21:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants