Workshop admins can move enrollments between workshops

[clareconstantine]

Workshop admins can now move enrollments from one workshop to another. This means engineer involvement is not necessary in the frequent requests to combine workshops, split up workshops, or even out enrollment between workshops.

PLC-305

No enrollments selected, Move button disabled:

Enrollment selected, Move button enabled:

Move enrollments dialog:

Error message if moving enrollments fails:

[breville]

UI-wise, I don't think we need to squeeze the dropdown button into a column header. I think it's fine to have it as a normal-sized button outside of the table, probably somewhere up and to the right. Maybe to the right of the download arrow.

[islemaster]

UI-wise, I don't think we need to squeeze the dropdown button into a column header. I think it's fine to have it as a normal-sized button outside of the table, probably somewhere up and to the right. Maybe to the right of the download arrow.

That would also make room for a select-all/deselect-all checkbox at the top of the column.

[agealy]

UI-wise, I don't think we need to squeeze the dropdown button into a column header. I think it's fine to have it as a normal-sized button outside of the table, probably somewhere up and to the right. Maybe to the right of the download arrow.

That would also make room for a select-all/deselect-all checkbox at the top of the column.

+1! i think that's where we initially planned for the button to go?

[islemaster]

I'd like to see an additional test confirming that a non-admin can't interact with this route at all.

[codecov-io]

Codecov Report

❗ No coverage uploaded for pull request base (staging@826bd39). Click here to learn what that means.
The diff coverage is 55%.

@@            Coverage Diff             @@
##             staging   #30017   +/-   ##
==========================================
  Coverage           ?   73.12%           
==========================================
  Files              ?     2049           
  Lines              ?   112131           
  Branches           ?     3399           
==========================================
  Hits               ?    81995           
  Misses             ?    26902           
  Partials           ?     3234

Flag	Coverage Δ
#integration	55.06% <ø> (?)
#storybook	56.61% <ø> (?)
#unit	58.12% <18.18%> (?)

Impacted Files	Coverage Δ
...llers/api/v1/pd/workshop_enrollments_controller.rb	94.73% <100%> (ø)
dashboard/config/routes.rb	100% <100%> (ø)
dashboard/app/models/ability.rb	100% <100%> (ø)
...ard/components/workshop_enrollment_school_info.jsx	42.73% <18.18%> (ø)

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 826bd39...ca19472. Read the comment docs.

[islemaster]

Awesome!

[breville]

Would it make sense for state to just hold the selected IDs, rather than duplicating this additional enrollment information into it?

[breville]

Would it be worth getting some test coverage of the UI, using UI automation and/or React tests?