Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Testing: Isolate workshop factories #30106

Merged
merged 5 commits into from Aug 5, 2019
Merged

Testing: Isolate workshop factories #30106

merged 5 commits into from Aug 5, 2019

Conversation

islemaster
Copy link
Contributor

@islemaster islemaster commented Aug 2, 2019

Using #29807 as a north-star but I keep trying to do too much, so here's a smaller isolation of our workshop factories before making further usability improvements to them.

@islemaster islemaster changed the title Testing: Better workshop factories Testing: Isolate workshop factories Aug 2, 2019
@islemaster islemaster marked this pull request as ready for review August 2, 2019 23:43
@codecov-io
Copy link

codecov-io commented Aug 2, 2019

Codecov Report

Merging #30106 into staging will decrease coverage by 0.06%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           staging   #30106      +/-   ##
===========================================
- Coverage    76.55%   76.48%   -0.07%     
===========================================
  Files          674      681       +7     
  Lines        27515    27668     +153     
===========================================
+ Hits         21064    21163      +99     
- Misses        6451     6505      +54
Impacted Files Coverage Δ
...llers/api/v1/peer_review_submissions_controller.rb 92% <0%> (-0.86%) ⬇️
dashboard/lib/sqs/queue_processor.rb 24.59% <0%> (ø)
dashboard/lib/sqs/sqs_queue.rb 100% <0%> (ø)
dashboard/lib/sqs/queue_processor_config.rb 100% <0%> (ø)
dashboard/lib/sqs/metrics.rb 46.66% <0%> (ø)
dashboard/lib/sqs/message.rb 66.66% <0%> (ø)
dashboard/lib/sqs/rate_limiter.rb 100% <0%> (ø)
dashboard/lib/sqs/messages_handler.rb 75% <0%> (ø)
lib/cdo/aws/metrics.rb 79.41% <0%> (+32.35%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 29c748c...baa21f9. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants