Export dialog: add iOS to UI flow #30115
Conversation
| return; | ||
| } | ||
| // TODO: use new URL format once snack-web has been updated for this flow | ||
| // TODO: pass iconUri and splashImageUri to expo.io |
There was a problem hiding this comment.
Are there work items for these?
There was a problem hiding this comment.
Also, for the link (below) should it redirect to the signup page? Right now, it sends me to a page with a bunch of code on it and I'm not sure what I'm supposed to do next.
There was a problem hiding this comment.
Yes, the snack-web changes are not yet available (that is what the TODO notes are indicating).
Once those changes are available on snack-web, this code will be updated to navigate to something like /publishipa/@:username/:projectName, which will redirect to signup/login and then explain the IPA export process.
| </p> | ||
| <p style={commonStyles.text}> | ||
| <b>Note: </b>You must have an Apple developer account to create an | ||
| IPA using our Code.org partner site, Expo.io. |
There was a problem hiding this comment.
Seems like this warning should be stronger @ryansloan - perhaps "REQUIRED: You must..."
|
Is there a design spec for the iOS route yet? I don't quite understand what the final product should look like? How much of this is going to be done by Snack Expo? |
@ryansloan can comment on the status of the spec. At this point, it looks like I will be doing the UI work on the Expo side based on the branch I referenced above. The Expo team is still working this week on completing the IPA build process. |
Codecov Report
@@ Coverage Diff @@
## staging #30115 +/- ##
==========================================
Coverage ? 68.21%
==========================================
Files ? 1369
Lines ? 84489
Branches ? 3415
==========================================
Hits ? 57637
Misses ? 23755
Partials ? 3097
Continue to review full report at Codecov.
|
|
@jmkulwik @cpirich There is not a spec on the Expo end of this yet. In order to do testing of the iOS export process we need to hook up our end of this. The expo team has prototyped an "export for app store" button on the snack page, but we need to work on the actual UI plan. This is behind an experiment flag separate from our Android release and we're not planning to release iOS at the same time. |
exportIOSexperiment) - based on export spec: https://docs.google.com/document/d/1o-C8GOi45FCzUKPRnsyrNS8k10jUYOlrP2zIBPeO1X4/editsnack-webchanges are not yet available. They will be based on the approach in this branch (for anyone who is curious): expo/snack-web@master...cpirich:cpirich/routes-for-save-and-publishipaNew screenshots (for review by @ryansloan):
