Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Widget Mode] Updated widget mode to auto-run on page load. #30138

Merged
merged 3 commits into from
Aug 8, 2019

Conversation

jmkulwik
Copy link
Contributor

@jmkulwik jmkulwik commented Aug 5, 2019

Removes the run/reset button and runs the app when the page loads.

image

Task: https://codedotorg.atlassian.net/browse/STAR-599

Spec: https://docs.google.com/document/d/1laYGDKIgW405YrnrWcURJDAhaKXeQPHrJ7BhyUqJMQE/edit#

Tests will be in a follow-up PR as widget mode is needed for a rapidly-approaching curriculum pilot.

@codecov-io
Copy link

codecov-io commented Aug 6, 2019

Codecov Report

❗ No coverage uploaded for pull request base (staging@0c18efc). Click here to learn what that means.
The diff coverage is 37.5%.

Impacted file tree graph

@@            Coverage Diff             @@
##             staging   #30138   +/-   ##
==========================================
  Coverage           ?   73.07%           
==========================================
  Files              ?     2045           
  Lines              ?   112156           
  Branches           ?     3409           
==========================================
  Hits               ?    81961           
  Misses             ?    26951           
  Partials           ?     3244
Flag Coverage Δ
#integration 55.51% <37.5%> (?)
#storybook 56.59% <0%> (?)
#unit 58.01% <0%> (?)
Impacted Files Coverage Δ
apps/src/StudioApp.js 63.34% <ø> (ø)
apps/src/applab/applab.js 84% <0%> (ø)
apps/src/applab/PhoneFrame.jsx 89.13% <75%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0c18efc...195d62a. Read the comment docs.

@jmkulwik jmkulwik merged commit 01d6bc8 into staging Aug 8, 2019
@jmkulwik jmkulwik deleted the widget-mode-autorun branch August 9, 2019 23:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants