Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use pegasus_unittest database for shared & pegasus unit tests during DTT #30181

Merged
merged 5 commits into from Aug 9, 2019

Conversation

davidsbailey
Copy link
Member

No description provided.

@davidsbailey
Copy link
Member Author

@wjordan , this is passing drone now, and passes locally when I manually modify test.yml.erb to unconditionally run the clear_secrets block and then run RAILS_ENV=test RACK_ENV=test rake test:shared_ci. Please take a look

task :pegasus_ci do
# isolate unit tests from the pegasus_test DB
ENV['PEGASUS_UNIT_TEST'] = '1'
TestRunUtils.run_shared_tests

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TestRunUtils.run_pegasus_tests?

@codecov-io
Copy link

codecov-io commented Aug 8, 2019

Codecov Report

❗ No coverage uploaded for pull request base (staging@e5a7572). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             staging   #30181   +/-   ##
==========================================
  Coverage           ?   73.07%           
==========================================
  Files              ?     2045           
  Lines              ?   112169           
  Branches           ?     3409           
==========================================
  Hits               ?    81969           
  Misses             ?    26956           
  Partials           ?     3244
Flag Coverage Δ
#integration 55.51% <ø> (?)
#storybook 56.59% <ø> (?)
#unit 58.01% <ø> (?)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e5a7572...060db84. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants