Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feedback: ViewFeedback component on student homepage #30197

Merged
merged 3 commits into from
Aug 8, 2019

Conversation

Erin007
Copy link
Contributor

@Erin007 Erin007 commented Aug 8, 2019

LP-661 - Permanent link to /feedback from the student homepage

New ViewFeedback component:
Screen Shot 2019-08-07 at 7 35 57 PM

will display in the Courses section of the student homepage if the user is a student, the feedbackNotification experiment is enabled, and the student has feedback:

student-homepage

Copy link
Contributor

@maddiedierker maddiedierker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

so excited to see this feature coming together!

Copy link
Member

@davidsbailey davidsbailey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work, Erin!


@has_feedback = TeacherFeedback.where(
student_id: current_user.id
).count > 0
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: can we skip this query if the user is a teacher?

@has_feedback = current_user.student? && TeacherFeedback.where(...

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

...or is it theoretically possible for a teacher in another teacher's section to want to see feedback from their teacher?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is theoretically possible for a teacher in another teacher's section to want to see feedback from their teacher, but we're only showing this component on the student homepage so I think skipping the query for teachers makes sense here.

@codecov-io
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (staging@0c18efc). Click here to learn what that means.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##             staging   #30197   +/-   ##
==========================================
  Coverage           ?   73.07%           
==========================================
  Files              ?     2046           
  Lines              ?   112172           
  Branches           ?     3409           
==========================================
  Hits               ?    81974           
  Misses             ?    26951           
  Partials           ?     3247
Flag Coverage Δ
#integration 55.51% <ø> (?)
#storybook 56.6% <100%> (?)
#unit 58.01% <100%> (?)
Impacted Files Coverage Δ
...pps/src/templates/studioHomepages/ViewFeedback.jsx 83.33% <100%> (ø)
dashboard/app/controllers/home_controller.rb 86.66% <100%> (ø)
.../src/templates/studioHomepages/StudentHomepage.jsx 90.38% <100%> (ø)
...ps/src/templates/studioHomepages/RecentCourses.jsx 90.74% <100%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0c18efc...7553a16. Read the comment docs.

@Erin007 Erin007 merged commit 4112737 into staging Aug 8, 2019
@Erin007 Erin007 deleted the feedback-homepage branch August 8, 2019 20:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants