-
Notifications
You must be signed in to change notification settings - Fork 480
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feedback: ViewFeedback component on student homepage #30197
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
so excited to see this feature coming together!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work, Erin!
|
||
@has_feedback = TeacherFeedback.where( | ||
student_id: current_user.id | ||
).count > 0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: can we skip this query if the user is a teacher?
@has_feedback = current_user.student? && TeacherFeedback.where(...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
...or is it theoretically possible for a teacher in another teacher's section to want to see feedback from their teacher?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is theoretically possible for a teacher in another teacher's section to want to see feedback from their teacher, but we're only showing this component on the student homepage so I think skipping the query for teachers makes sense here.
Codecov Report
@@ Coverage Diff @@
## staging #30197 +/- ##
==========================================
Coverage ? 73.07%
==========================================
Files ? 2046
Lines ? 112172
Branches ? 3409
==========================================
Hits ? 81974
Misses ? 26951
Partials ? 3247
Continue to review full report at Codecov.
|
LP-661 - Permanent link to /feedback from the student homepage
New
ViewFeedback
component:will display in the Courses section of the student homepage if the user is a student, the
feedbackNotification
experiment is enabled, and the student has feedback: