More realistic workshop factories #30296
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
islemaster
changed the base branch from
staging
to
realistic-workshop-factories
islemaster
force-pushed
the
more-realistic-workshop-factories
branch
from
03e2ab4
to
148f1e7
Compare
Codecov Report
@@ Coverage Diff @@
## staging #30296 +/- ##
========================================
Coverage 76.77% 76.77%
========================================
Files 678 678
Lines 27688 27688
========================================
Hits 21258 21258
Misses 6430 6430Continue to review full report at Codecov.
|
islemaster
changed the base branch from
realistic-workshop-factories
to
staging
islemaster
force-pushed
the
more-realistic-workshop-factories
branch
from
af4d7c5
to
6709b54
Compare
clareconstantine
approved these changes
Aug 19, 2019
| @@ -648,7 +655,10 @@ class ApplicationsControllerTest < ::ActionController::TestCase | |||
| time = Date.new(2017, 3, 15) | |||
|
|
|||
| Timecop.freeze(time) do | |||
| workshop = create :workshop, :local_summer_workshop, num_sessions: 3, sessions_from: Date.new(2017, 1, 1), processed_location: {city: 'Orchard Park', state: 'NY'}.to_json | |||
| workshop = create :summer_workshop, | |||
| num_sessions: 3, | |||
There was a problem hiding this comment.
I don't think there is a reason that this needs to have 3 sessions - it looks like it could be a standard 5-day summer workshop
| @@ -780,7 +790,10 @@ class ApplicationsControllerTest < ::ActionController::TestCase | |||
| time = Date.new(2017, 3, 15) | |||
|
|
|||
| Timecop.freeze(time) do | |||
| workshop = create :workshop, :local_summer_workshop, num_sessions: 3, sessions_from: Date.new(2017, 1, 1), processed_location: {city: 'Orchard Park', state: 'NY'}.to_json | |||
| workshop = create :summer_workshop, | |||
| num_sessions: 3, | |||
There was a problem hiding this comment.
same here - could just go with the default 5 sessions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Continuing work started in #30281 to clean up our workshop factories and make them more realistic - specifically reflecting the workshop types that we're actively supporting.
This particular change adds support for CSD and CSP summer workshops, and removes the old summer workshop traits.