[Applab Datasets] Set Up Layout for new Data Tab #30331
Conversation
Codecov Report
@@ Coverage Diff @@
## staging #30331 +/- ##
===========================================
- Coverage 73.28% 72.13% -1.15%
===========================================
Files 2050 1374 -676
Lines 112326 84689 -27637
Branches 3424 3427 +3
===========================================
- Hits 82313 61091 -21222
+ Misses 26773 20353 -6420
- Partials 3240 3245 +5
Continue to review full report at Codecov.
|
ajpal
changed the title
| borderRight: '1px solid gray', | ||
| overflowY: 'auto', | ||
| padding: 10, | ||
| paddingRight: 0 // setting this to 0 allows 2 columns with the potential scrollbar on Windows |
There was a problem hiding this comment.
In which cases is this needed? I pulled the branch really quick to test it out, and disabling this didn't cause a difference on IE or Chrome. Does this have a bigger effect when there is scrollable data?
There was a problem hiding this comment.
I think you might also be able to go without display: 'block'
There was a problem hiding this comment.
Would it make more sense to make the width 250 and go without the border-box? Not sure which is clearer, but it's an option.
| width: 270, | ||
| boxSizing: 'border-box', | ||
| borderRight: '1px solid gray', | ||
| overflowY: 'auto', |
| bottom: 0, | ||
| left: 270, | ||
| right: 0, | ||
| boxSizing: 'border-box', |
There was a problem hiding this comment.
I think you don't need border-box here
There was a problem hiding this comment.
(same with the container)
Right now just the basic layout. Next step is the Data Browser content, then the Library Pane content. Everything behind an experiment flag.
With Experiment on:
With Experiment off:
