Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add developer permissions to manage secrets in CfnStack namespace #30377

Merged
merged 2 commits into from Aug 23, 2019

Conversation

wjordan
Copy link
Contributor

@wjordan wjordan commented Aug 22, 2019

This extra permission is needed to be able to create adhoc instances from Developer federated role via the dev-permission CloudFormationService service role. The namespace is used by the AWS::SecretsManager::Secret resource named DatabaseSecret in the cloudformation stack template.

@wjordan wjordan requested a review from sureshc August 22, 2019 20:37
@wjordan
Copy link
Contributor Author

wjordan commented Aug 22, 2019

I've already manually applied the change listed here to the IAM stack- I will merge this code change once the updated permissions are confirmed working for new adhoc deployments.

@wjordan wjordan force-pushed the cfnstack-secret-permissions branch from 38343ee to bf77a90 Compare August 22, 2019 20:53
@wjordan wjordan force-pushed the cfnstack-secret-permissions branch from bf77a90 to 94f2ed0 Compare August 22, 2019 21:17
@wjordan wjordan merged commit aed0839 into staging Aug 23, 2019
@wjordan wjordan deleted the cfnstack-secret-permissions branch August 23, 2019 01:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant