Reintroduce mp3 audio recording with fixed UI test #30402
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmkulwik
changed the title
|
Note: In the first drone run Chrome_applab_data_blocks is the ui test that failed. Did not repro locally running via saucelabs. Rerunning. |
ajpal
approved these changes
Aug 23, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reintroduces the reverted audio-as-mp3 feature with a fixed UI test. Most changes have been reviewed as part of this pr: #30360
The only diff from that change are the commits regarding failing tests.
The UI test failed because recording audio in Safari was disabled in the past, but has been re-enabled as part of this change. Safari tests are not run as part of drone runs which is why it didn't fail until DTT. I've manually run the safari test through sauce labs and it succeeds now.