Fix pd-workshop-survey contact_id reference #30503
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This survey partial still contained a reference to regional_partners.contact_id, which was removed in #30445. Instead, I'm using the workshop's regional_partner_id to do a regional partner lookup. This is intentionally a shallow fix, no cleanup or refactoring; I'm just trying to quickly correct what looks like a regression on production. We're hoping to deprecate this view soon anyway.
hacodeorg
approved these changes
Aug 29, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This survey partial still contained a reference to
regional_partners.contact_id, which was removed in #30445. Instead, I'm using the workshop's regional_partner_id to do a regional partner lookup so we can populate a hidden field on the form.This is intentionally a shallow fix, no cleanup or refactoring; I'm just trying to quickly correct what looks like a regression on production (Honeybadger). We're hoping to deprecate this view soon anyway.