Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extract p5-dependencies.js chunk #30520

Merged
merged 3 commits into from Sep 3, 2019
Merged

Extract p5-dependencies.js chunk #30520

merged 3 commits into from Sep 3, 2019

Conversation

joshlory
Copy link
Contributor

Screen Shot 2019-08-29 at 11 55 37 AM

With PR #30510, more p5-specific code will be pulled into the common.js chunk. Create a separate p5-dependencies.js chunk for gamelab, spritelab & dance.

Copy link
Member

@davidsbailey davidsbailey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

I haven't pulled down the branch to double-check, but I think it may now be possible for use_gamelab to be removed.

@codecov-io
Copy link

Codecov Report

Merging #30520 into staging will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff             @@
##           staging   #30520      +/-   ##
===========================================
+ Coverage    73.21%   73.22%   +<.01%     
===========================================
  Files         2055     2055              
  Lines       112942   112846      -96     
  Branches      3486     3485       -1     
===========================================
- Hits         82694    82629      -65     
+ Misses       26970    26962       -8     
+ Partials      3278     3255      -23
Flag Coverage Δ
#integration 69.17% <ø> (+13.43%) ⬆️
#storybook 56.52% <ø> (-0.04%) ⬇️
#unit ?
Impacted Files Coverage Δ
dashboard/app/helpers/levels_helper.rb 85.44% <100%> (ø) ⬆️
.../application_dashboard/admin_cohort_view_table.jsx 37.5% <0%> (-1.98%) ⬇️
...udio/pd/application_dashboard/quick_view_table.jsx 33.68% <0%> (-1.67%) ⬇️
...d/workshop_dashboard/components/workshop_table.jsx 32.43% <0%> (-1.49%) ⬇️
apps/src/templates/manageStudents/MoveStudents.jsx 75.83% <0%> (-0.36%) ⬇️
apps/src/templates/tables/wrapped_sortable.js 100% <0%> (ø) ⬆️
...c/templates/manageStudents/ManageStudentsTable.jsx 79.51% <0%> (+0.1%) ⬆️
...s/src/templates/projects/FeaturedProjectsTable.jsx 79.78% <0%> (+0.19%) ⬆️
...ctionAssessments/MatchAssessmentsOverviewTable.jsx 81.11% <0%> (+0.26%) ⬆️
...dio/pd/application_dashboard/cohort_view_table.jsx 81.11% <0%> (+0.26%) ⬆️
... and 18 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ff60929...d17501b. Read the comment docs.

@joshlory
Copy link
Contributor Author

joshlory commented Sep 3, 2019

I think use_gamelab is still needed for now, but should go away with PR #30510.

@joshlory joshlory merged commit f1452ec into staging Sep 3, 2019
@joshlory joshlory deleted the p5-dependencies-chunk branch September 3, 2019 17:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants