Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Populate starter assets with real data #30526

Merged
merged 10 commits into from Sep 3, 2019
Merged

Conversation

maddiedierker
Copy link
Contributor

@maddiedierker maddiedierker commented Aug 29, 2019

Finishes LP-609, by hooking up starter assets to use real data from the server!

Video of usage (not the most beautiful image choice, though):
out

@codecov-io
Copy link

codecov-io commented Sep 3, 2019

Codecov Report

Merging #30526 into staging will decrease coverage by <.01%.
The diff coverage is 93.33%.

Impacted file tree graph

@@             Coverage Diff             @@
##           staging   #30526      +/-   ##
===========================================
- Coverage    73.22%   73.21%   -0.01%     
===========================================
  Files         2056     2056              
  Lines       112995   113020      +25     
  Branches      3490     3491       +1     
===========================================
+ Hits         82739    82753      +14     
- Misses       26977    26987      +10     
- Partials      3279     3280       +1
Flag Coverage Δ
#integration 55.73% <53.84%> (-0.02%) ⬇️
#storybook 56.55% <43.47%> (ø) ⬆️
#unit 58.09% <80.76%> (ø) ⬆️
Impacted Files Coverage Δ
dashboard/app/helpers/levels_helper.rb 85.48% <100%> (+0.03%) ⬆️
apps/src/applab/redux/applab.js 97.43% <100%> (+0.46%) ⬆️
apps/src/applab/applab.js 83.98% <100%> (+0.02%) ⬆️
dashboard/app/controllers/levels_controller.rb 93.78% <100%> (+0.03%) ⬆️
...app/controllers/level_starter_assets_controller.rb 89.47% <100%> (ø) ⬆️
dashboard/app/models/levels/blockly.rb 95.43% <100%> (+0.01%) ⬆️
apps/src/assetManagement/assetPrefix.js 73.07% <100%> (-2.48%) ⬇️
apps/src/code-studio/components/ImagePicker.jsx 66.03% <66.66%> (-1.36%) ⬇️
apps/src/code-studio/components/AssetManager.jsx 51.47% <75%> (+0.35%) ⬆️
apps/src/logToCloud.js 28.78% <0%> (-7.58%) ⬇️
... and 7 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0806447...18376eb. Read the comment docs.

@maddiedierker maddiedierker merged commit 03d0905 into staging Sep 3, 2019
@maddiedierker maddiedierker deleted the starter-assets-4 branch September 3, 2019 23:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants