Differentiate Deep Dive workshops on map #30549
Conversation
islemaster
requested review from
agealy,
breville,
clareconstantine and
hacodeorg
| @@ -85,6 +91,13 @@ function createNewMarker(latLng, title, infoWindowContent) { | |||
| return marker; | |||
| } | |||
|
|
|||
| function iconForSubject(subject) { | |||
| if (subject === 'Deep Dive') { | |||
There was a problem hiding this comment.
Can we hoist 'Deep dive' into a common string?
| @@ -118,7 +118,9 @@ def k5_public_map_index | |||
| # will be to show workshops from all subjects when deep-dive isn't specified. | |||
| # But until then, when deep-dive isn't specified, we only show 'Intro' | |||
| # workshops. | |||
| conditions[:subject] = params['deep_dive_only'] ? 'Deep Dive' : 'Intro' | |||
| if params['deep_dive_only'] | |||
There was a problem hiding this comment.
Does this change the comment above it?
There was a problem hiding this comment.
Whoops, yes - it makes it irrelevant. Removing!
Codecov Report
@@ Coverage Diff @@
## staging #30549 +/- ##
===========================================
+ Coverage 73.21% 73.21% +<.01%
===========================================
Files 2058 2057 -1
Lines 112978 112945 -33
Branches 3495 3493 -2
===========================================
- Hits 82721 82698 -23
+ Misses 26995 26986 -9
+ Partials 3262 3261 -1
Continue to review full report at Codecov.
|
1 similar comment
Codecov Report
@@ Coverage Diff @@
## staging #30549 +/- ##
===========================================
+ Coverage 73.21% 73.21% +<.01%
===========================================
Files 2058 2057 -1
Lines 112978 112945 -33
Branches 3495 3493 -2
===========================================
- Hits 82721 82698 -23
+ Misses 26995 26986 -9
+ Partials 3262 3261 -1
Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@
## staging #30549 +/- ##
===========================================
+ Coverage 73.21% 73.21% +<.01%
===========================================
Files 2058 2057 -1
Lines 112978 112945 -33
Branches 3495 3493 -2
===========================================
- Hits 82721 82698 -23
+ Misses 26995 26986 -9
+ Partials 3262 3261 -1
Continue to review full report at Codecov.
|
PLC-417 Displays different map info and pin colors depending on whether a CSF workshop is Intro or Deep Dive on code.org/professional-development-workshops/update.
Adds Deep Dive workshops to the map on this page.
Deep Dive workshops get a star on their pin. We collapse workshops at the same location into one pin - in these cases if any of the workshops is deep dive, the pin gets the star. Also adds the workshop subject to the tooltip.
Before:
After:
