changing CGI.escape to URI.encode to replace '+' with '%20' #30570
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…utlook renders spaces
breville
approved these changes
Sep 3, 2019
There was a problem hiding this comment.
Per chat, this seems like a reasonable short-term fix, but there are some longer term options which are not deprecated. cc @davidsbailey
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is to enable Outlook email clients opening the email link to render spaces instead of the '+' literally, which is what happens when CGI uses '+' as the separator.
URI.encode is an alias for URI.escape, which was deprecated in 2009. However, we use URI.encode in several other places in our codebase. Since the marketing wants to send out the CSP privacy notice tomorrow, this is a quick fix to address the spaces issue.