DTT (Staging > Test) [robo-dtt] #30618
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…sts from user_test.rb) into standalone helper
…ct it's no longer contained in a larger test (use setup, etc)
Originally added in #13107, this piece of code seems to be intended to provide for a graceful release of a feature, but that was never followed up on. It's currently nonfunctional and is adding code to our already-overlarge User model, so I'd like to remove it.
Originally defined in #3165, this is no longer actually used
These methods are already defined on the SchoolInfoInterstitialHelper, we can just use them directly there. Also move the helper from `lib` into the helpers directory
The "My name is not on this list" link at the bottom of the session attendance page (at https://studio.code.org/pd/attend/[code]) was not being noticed, so now it's bigger and a button.
Remove `school_info_optional?` check from users
Remove 'advertised scripts' helper methods from User model
…stitial-helper Remove school info interstitial passthrough methods from User model
Clean up FollowersController
Fix z-index for teacher panel & hamburger menu
…igger PL: Make attendance link more obvious
…i-test Add skip tag to workshop_dashboard ui test
…-helper Extract race interstitial helper logic from user.rb
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.