Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add link in button for CPE firmware update #30727

Merged
merged 1 commit into from Sep 16, 2019
Merged

Conversation

epeach
Copy link

@epeach epeach commented Sep 11, 2019

Previous implementation only had option to update firmware for CPC:
Screenshot from 2019-09-11 15-42-20

This PR adds a link to the Adafruit website which directs users how to flash the CPE firmware, since we are no longer pursuing flashing that automatically.
Screenshot from 2019-09-11 15-41-21

Both options are hidden behind 'flash-classic' experiment flag.
Next steps: implementing check for firmware implementation in CPFirmata.

@codecov-io
Copy link

codecov-io commented Sep 11, 2019

Codecov Report

❗ No coverage uploaded for pull request base (staging@2dd32ab). Click here to learn what that means.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##             staging   #30727   +/-   ##
==========================================
  Coverage           ?   71.96%           
==========================================
  Files              ?     1383           
  Lines              ?    85664           
  Branches           ?     3530           
==========================================
  Hits               ?    61652           
  Misses             ?    20706           
  Partials           ?     3306
Flag Coverage Δ
#integration 55.75% <ø> (?)
#storybook 56.44% <ø> (?)
#unit 58.13% <0%> (?)
Impacted Files Coverage Δ
apps/src/lib/kits/maker/ui/SetupChecklist.jsx 79.25% <0%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2dd32ab...e3da4f2. Read the comment docs.

@epeach epeach merged commit e6e87b7 into staging Sep 16, 2019
@epeach epeach deleted the CPE-update-firmware-setp branch September 16, 2019 20:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants