Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Applab Datasets] Make current tables read-only #30863

Merged
merged 3 commits into from Sep 25, 2019

Conversation

ajpal
Copy link
Contributor

@ajpal ajpal commented Sep 19, 2019

Students are not able to edit data from current tables

Before:
image

After:
image

@ajpal ajpal changed the base branch from staging to sep19-current-table-simple September 19, 2019 22:56
FirebaseStorage.deleteTable('mytable', verifyNoTable, error => {
throw error;
});
FirebaseStorage.deleteTable(
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does deleteTable accept 4 params or does it need to be updated?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's was leftover from when this was based off #30861, should be gone now

@ajpal ajpal changed the base branch from sep19-current-table-simple to staging September 25, 2019 17:08
Copy link

@epeach epeach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ajpal ajpal merged commit 33ce137 into staging Sep 25, 2019
@ajpal ajpal deleted the sep19-current-tables-readonly branch September 25, 2019 18:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants