Safe markdown: consolidate delete account strings #30969
Conversation
|
@dju90 I haven't found a way to open a markdown link in a new tab. From my findings, the default is still using html. This will impact consolidating the strings. Do we still want to open the link in a new tab (this seems to be a common best practice)? Current: link opens in a new tab New implementation: link does not open in a new tab |
|
Since it goes to a *.code.org domain, I would be fine not opening it in a new tab. I think standard is to open in a new tab only if it goes to an external site (and sometimes not even then), so we're good here to open in the same tab. |
|
The recommended standard is to open links in a new tab if and only if opening them in the current tab would cause the user to lose some progress; if the current tab contains a form, for example, that the user might be in the process of filling out but which is not saved. |
apps/i18n/common/en_us.json
Outdated
| "deleteAccount_teacherWarning5": "sending home instructions for creating personal logins. ", | ||
| "deleteAccount_teacherWarning6": "Give them at least a few days to follow these instructions BEFORE you delete your account.", | ||
| "deleteAccount_teacherWarning1": "Deleting your account will permanently erase all personal information, coursework, projects, and professional learning information connected to this account after 28 days. **It will also delete your sections and your students’ accounts** that don’t have a personal login or aren’t in another teacher’s section. Please make sure you have the authority to delete these students’ education records before deleting your own account. ", | ||
| "deleteAccount_teacherWarning2": "Give these students a chance to keep using their Code.org accounts by [sending home instructions for creating personal logins.]({explanationUrl}) Give them at least a few days to follow these instructions BEFORE you delete your account.", |
There was a problem hiding this comment.
we'll need to create these as new strings, so the old translations aren't carried over
There was a problem hiding this comment.
We should also take this opportunity to give these strings more descriptive names
|
Will this change be caught by the sync up today? If so, I can let someone on the international program know so that we can reach out to the translator who reported it :D |
|
@dju90 Yes. I added the string to the list I shared with Jorge |
The objective is to consolidate delete account strings to improve translation experience.
Implementation
Screen shots