Part 1, take 2: only partially remove unminify plugin #30971
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Background
Reverts #30964, restoring #30831 which attempted to remove the
UnminifyWebpackPlugin
. The first attempt broke unit tests on the test machine (see #30964) because the exporter tests for applab and gamelab expect certain unminified files to exist in the webpack output underapps/build/package/js/
. These passed on drone because drone does an unminified webpack build before running apps unit tests.Description
This PR augments the initial attempt by reinstating
UnminifyWebpackPlugin
and limiting it to the files which are needed by the exporter tests.Verification
Verified locally that the exporter tests fail after
grunt clean
, then pass again afteryarn build:dist
.