Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Part 1, take 2: only partially remove unminify plugin #30971

Merged
merged 3 commits into from Sep 26, 2019

Conversation

davidsbailey
Copy link
Member

@davidsbailey davidsbailey commented Sep 26, 2019

Background

Reverts #30964, restoring #30831 which attempted to remove the UnminifyWebpackPlugin. The first attempt broke unit tests on the test machine (see #30964) because the exporter tests for applab and gamelab expect certain unminified files to exist in the webpack output under apps/build/package/js/. These passed on drone because drone does an unminified webpack build before running apps unit tests.

Description

This PR augments the initial attempt by reinstating UnminifyWebpackPlugin and limiting it to the files which are needed by the exporter tests.

Verification

Verified locally that the exporter tests fail after grunt clean, then pass again after yarn build:dist.

@davidsbailey davidsbailey changed the title partially remove unminify plugin only partially remove unminify plugin Sep 26, 2019
@davidsbailey davidsbailey changed the title only partially remove unminify plugin Part 1, take 2: only partially remove unminify plugin Sep 26, 2019
Copy link
Contributor

@islemaster islemaster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great diagnosis and fix. I'm glad the test machine caught this! Sorry I didn't remember it earlier.

One wonders if we should (in the future) do more to separate these "special case" bundles that we want to leave minified out from the rest of our pipeline - I imagine we don't want to do any automatic bundle splitting on them either.

@davidsbailey
Copy link
Member Author

One wonders if we should (in the future) do more to separate these "special case" bundles that we want to leave minified out from the rest of our pipeline - I imagine we don't want to do any automatic bundle splitting on them either.

Good point -- we exclude these otherEntries from our explicit cacheGroups, but I am not sure they get excluded from the defaults. The defaults only affect on-demand chunks, which we don't have yet, but webpack may still be searching these giant entry points to look for them and may be doing other extra work too.

@davidsbailey davidsbailey merged commit 206537a into staging Sep 26, 2019
@davidsbailey davidsbailey deleted the remove-unminify-plugin-again branch September 26, 2019 16:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants