Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename workshop factory file #31006

Merged
merged 2 commits into from Sep 30, 2019
Merged

Rename workshop factory file #31006

merged 2 commits into from Sep 30, 2019

Conversation

clareconstantine
Copy link

@clareconstantine clareconstantine commented Sep 27, 2019

Description

Renamed this file to fit our naming convention and be easier to find. When looking for it for another change, I knew it existed but had to browse to it because it didn't have "factories" in the name, which I was expecting.

I also fixed a typo.

@clareconstantine clareconstantine requested review from islemaster and hacodeorg and removed request for islemaster September 27, 2019 22:26
Copy link
Contributor

@islemaster islemaster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯 👍

@@ -215,7 +215,7 @@
# CSP local summer workshop by default
csp

location_name 'Greedale Community College'
location_name 'Greendale Community College'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😂

@clareconstantine clareconstantine merged commit faa85aa into staging Sep 30, 2019
@clareconstantine clareconstantine deleted the rename-ws-factories branch September 30, 2019 20:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants