Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Performance opt height #31034

Merged
merged 3 commits into from Oct 1, 2019
Merged

Performance opt height #31034

merged 3 commits into from Oct 1, 2019

Conversation

epeach
Copy link

@epeach epeach commented Sep 30, 2019

Description

Removing unnecessary height adjustments to try and optimize the performance that is causing Minecraft to crash browsers.

Performance of connecting blocks on staging, at a x6 throttle
Screenshot from 2019-09-30 14-16-31

Performance of connecting blocks on this branch, at a x6 throttle
Screenshot from 2019-09-30 14-20-55

Links

Testing story

Reviewer Checklist:

  • Tests provide adequate coverage
  • Code is well-commented
  • New features are translatable or updates will not break translations
  • Relevant documentation has been added or updated
  • User impact is well-understood and desirable
  • Pull Request is labeled appropriately
  • Follow-up work items (including potential tech debt) are tracked and linked

@epeach epeach merged commit 5770c49 into staging Oct 1, 2019
@epeach epeach deleted the performance-opt-height branch October 1, 2019 19:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants