Make application front end components and file names year-agnostic #31044
Conversation
clareconstantine
changed the base branch from
staging
to
principal-approval-2021
| hasIncompleteApplication={ | ||
| !!sessionStorage['Teacher2021Application'] | ||
| } | ||
| hasIncompleteApplication={!!sessionStorage['TeacherApplication']} |
There was a problem hiding this comment.
Is there any chance of an earlier year's application being loaded at this point?
There was a problem hiding this comment.
ooh, I guess that could be an issue in future years if they had a partial application in session storage, but this year it wouldn't be an issue since the session storage key name hasn't been used for this before. Also, I think it's unlikely that a user would have a session open a year later with an in-progess application from a previous year - this gets reset if they close the session, right?
There was a problem hiding this comment.
but we could keep this part year-specific if that feels safer
There was a problem hiding this comment.
I think the session storage is very short-lived, so in reality this probably won't be an issue. But it's worth being aware of. In fact, the bigger issue might be that we should be using something that lasts longer, but that's probably out of scope here.
If it's easy to parameterize with the current year, that feels like the safest option. Otherwise, I think getting rid of per-year code changes is worth it in this case.
clareconstantine
changed the base branch from
principal-approval-2021
to
eyes-staging
Description
We only ever have one live version of the teacher app, principal approval, and facilitator app. Having the year in the file and component names creates more work for us every year to rename all of these.
Jira task