Remove gsheet-based summing for state promote #31056
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Long ago (in #3591) we apparently took advantage of an extra row in the cdo-state-promote gsheet that was labeled with "Sum_states" rather than a state itself. This caused an issue in the iterator at https://github.com/code-dot-org/code-dot-org/blob/staging/pegasus/rake/generate_pdfs.rake#L21 when we attempted to generate a PDF for a state of "Sum_states". With this change, we just do the summing in the SQL query, rather than relying upon the sum generated by the gsheet. This will allow us to simultaneously remove the row from the gsheet.
islemaster
approved these changes
Oct 2, 2019
agealy
approved these changes
Oct 2, 2019
uponthesun
approved these changes
Oct 2, 2019
|
@uponthesun Good question. Front-ends caches these pages locally with varnish and they are cached again by the CDN, so we're pretty good on performance, but it turns out |
|
Just merged this and also removed the final row from the gsheet simultaneously. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Long ago we apparently took advantage of an extra row in the
cdo-state-promotegsheet that was labeled with"Sum_states"rather than a state itself. This has since caused an issue in an iterator when we attempted to generate a PDF for a state of "Sum_states".With this change, we just do the summing in the SQL query, rather than relying upon the sum generated by the gsheet. This will allow us to simultaneously remove the row from the gsheet.