Prevent html injection in sign up form: Use string that includes markdown #31074
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nkiruka
force-pushed
the
sanitize-i18n-new-sign-up-form
branch
from
666a3c4
to
1a5e12e
Compare
maddiedierker
approved these changes
Oct 7, 2019
nkiruka
changed the title
nkiruka
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Replace the string "signup_form.student_terms" with "signup_form.student_terms_markdown"
signup_form.student_terms_markdown uses markdown to prevent html injection in the signup form.
"student_terms" string does not exist
Reviewer Checklist: