Assignment Updates: auto select first unit if a course is assigned to a new section #31179
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidsbailey
reviewed
Oct 9, 2019
Comment on lines
259
to
269
| // If the user is setting up a new section and selects a course as the | ||
| // primary assignment, default the secondary assignment to the first | ||
| // script in the course. | ||
| const noCurrentSecondaryAssignment = selectedSecondaryId === 'null_null'; | ||
| const defaultScriptId = assignments[selectedPrimaryId] | ||
| ? assignments[selectedPrimaryId].scriptAssignIds[0] | ||
| : null; | ||
| const secondaryId = | ||
| newSection && noCurrentSecondaryAssignment | ||
| ? defaultScriptId | ||
| : selectedSecondaryId; |
| @@ -323,12 +336,11 @@ export default class AssignmentSelector extends Component { | |||
| </div> | |||
| <select | |||
| id="uitest-secondary-assignment" | |||
| value={selectedSecondaryId} | |||
| value={secondaryId} | |||
There was a problem hiding this comment.
this could end up being undefined (if there are no scriptAssignIds) or null. does the right thing happen in both cases?
|
@davidsbailey I revised and updated/extended test coverage. Can you take another look when you get a chance, please? Thanks! |
davidsbailey
approved these changes
Oct 11, 2019
| @@ -337,6 +348,7 @@ export default class AssignmentSelector extends Component { | |||
| </option> | |||
| ) | |||
| )} | |||
| <option value={noAssignment} /> | |||
There was a problem hiding this comment.
why is this at the end now? I think we would want to have a good reason to change this if it affects the ordering in the UI.
There was a problem hiding this comment.
Oh, Amanda asked me to move it to make it slightly less likely that folks will pick this option.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
New Sections
When a teacher is a creating a new section and selects a course for the primary assignment dropdown, we will now default the secondary assignment dropdown to the first unit in that course. Previously, we defaulted the secondary assignment dropdown to the empty option.
Existing Sections
If a teacher is editing an existing section and a primary and secondary assignment is already selected, we preserve those selections.
Even if the secondary assignment selected is empty. This is because the teacher may have intentionally not assigned a unit. This is a rare, but valid, use case.
Additionally, the "no assignment" option is now the last option in the secondary assignment dropdown rather than the first.
Links
Testing story
Reviewer Checklist: