Stop showing cohort capacity #31433
Merged
Stop showing cohort capacity #31433
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… Remove logic restricting the cohort calculator to only display when a partner has specified their cohort size.
…ts has been deprecated, in favor of keyword arguments, and will be removed in Rails 5.1.
hacodeorg
commented
Oct 23, 2019
| @@ -249,13 +249,13 @@ class Api::V1::RegionalPartnersControllerTest < ActionController::TestCase | |||
| test 'show regional partner summer workshops for valid partner ID' do | |||
| regional_partner = create :regional_partner_beverly_hills | |||
|
|
|||
| get :show, partner_id: regional_partner.id | |||
| get :show, params: {partner_id: regional_partner.id} | |||
There was a problem hiding this comment.
This is to fix a deprecation warning while running tests in RubyMine
Using positional arguments in functional tests has been deprecated, in favor of keyword arguments, and will be removed in Rails 5.1.
hacodeorg
commented
Oct 23, 2019
| capacity: null, | ||
| loadingRegistrationCount: null, | ||
| registered: null | ||
| loadingEnrollmentCount: null, |
There was a problem hiding this comment.
I change loadingRegistrationCount to loadingEnrollmentCount and registered to enrolled to match the function name and value returned from the server side.
agealy
approved these changes
Oct 24, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
PLC-574
Remove "available seats" and "remaining capacity" rows from the cohort calculator
Remove logic restricting the cohort calculator to only display when a partner has specified their cohort size.
Remove "Cohort capacity csd" and "Cohort capacity csp" fields from the regional partner edit view and the regional partner info view
Testing story
Manual tests on local host.