DTL (Test > Levelbuilder): 01fab80e #31440
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…pen to delay loading data.
…w, but will be moved to the backend.
remove unused country-resources.md i18n files
DTT (Staging > Test) [robo-dtt]
Application notification emails that would normally go to our regional partners should instead be sent to Liz when no partner was matched for a given application. At this time there's only one such notification (that a principal approval form was completed) and we were simply skipping it when no partner was found.
Add new feedback strings for Dance Party 2019
Minor updates to application dashboard
DTT (Staging > Test) [robo-dtt]
As it turns out, emails don't use the rendering logic I updated in #31362 and so don't need to stop using ERB in their YAML header just yet; they use https://github.com/code-dot-org/code-dot-org/blob/staging/lib/cdo/pegasus/text_render.rb, specifically https://github.com/code-dot-org/code-dot-org/blob/8bfb480e91fec4a6e39d3727634d26f85b73f4df/lib/cdo/pegasus/text_render.rb#L190-L205 which still supports ERB (see https://github.com/code-dot-org/code-dot-org/blob/8bfb480e91fec4a6e39d3727634d26f85b73f4df/bin/cron/deliver_poste_messages#L63-L74 for more details). In addition, they actually only define @Header if one is detected, so the change to assign metadata directly to that variable was failing because it never got initialized. Reverting these templates to their old format fixes things for now, and I'll track longer-term work to update YamlEngine
…-unit-overview-section-assigner Revert "Revert "Assignment Updates: SectionAssigner on unit overview""
DTT (Staging > Test) [robo-dtt]
…-create-new-404-page-dashboard Revert "Revert "404 page dashboard - Route 404 errors to haml page""
[student-libraries] Allow finding and importing libraries from classmates
DTT (Staging > Test) [robo-dtt]
…ails Restore ERB in YAML header for email templates
DTT (Staging > Test) [robo-dtt]
Clean up library dialog
DTT (Staging > Test) [robo-dtt]
DTS (Levelbuilder > Staging) [robo-dts]
our application doesn't depend on `LAST_INSERT_ID()`, so we don't need to disable multiplexing after inserts. [ci skip]
Enable Proxysql on frontends by default
DTT (Staging > Test) [robo-dtt]
Default notifications to Liz when partner is missing
DTT (Staging > Test) [robo-dtt]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.