Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix teacher application scholarship evaluation #31449

Merged
merged 2 commits into from Oct 24, 2019
Merged

Fix teacher application scholarship evaluation #31449

merged 2 commits into from Oct 24, 2019

Conversation

hacodeorg
Copy link
Contributor

@hacodeorg hacodeorg commented Oct 24, 2019 •
edited

Description

Change the logic in scholarship evaluation to accept the application when at least one of the criteria is YES.
PLC-580

Testing story

  • Add unit test
  • Manual test with application on development
    • Manipulate scholarship scores of an application then verify result on teacher application detail view 
      app = Pd::Application::Teacher2021Application.find(1)
app.update(response_scores: {meets_scholarship_criteria_scores: {underrepresented_minority_percent: 50, free_lunch_percent:nil}, meets_minimum_criteria_scores: {csd_which_grades: 'Yes',committed: 'Yes',plan_to_teach: 'Yes',previous_yearlong_cdo_pd: 'Yes',replace_existing: 'Yes',principal_approval: 'Yes', principal_schedule_confirmed: 'Yes'}}.to_json)

@hacodeorg hacodeorg marked this pull request as ready for review October 24, 2019 00:59
islemaster
islemaster approved these changes Oct 24, 2019
View reviewed changes
Copy link
Contributor

@islemaster islemaster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome test!

@agealy
Copy link

agealy commented Oct 24, 2019

thanks for moving quickly on this!

@hacodeorg hacodeorg merged commit 48a17c7 into staging Oct 24, 2019
@hacodeorg hacodeorg deleted the ha/ta-scholarship-criteria branch October 24, 2019 17:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@islemaster islemaster islemaster approved these changes

@agealy agealy agealy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@hacodeorg @agealy @islemaster