Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Sprite Lab/ Dance Party] Generate unique names for named sprites/dancers #31451

Merged
merged 1 commit into from Oct 24, 2019
Merged

[Sprite Lab/ Dance Party] Generate unique names for named sprites/dancers #31451

merged 1 commit into from Oct 24, 2019

Conversation

ajpal
Copy link
Contributor

@ajpal ajpal commented Oct 24, 2019

Description

Regression from #31138 and #30979
Named sprites are no longer variable assignments, but we still want to generate unique names for them.
Dance
Before:
image

After:
image

Sprite Lab
Before:
image

After:
image

Reviewer Checklist:

  • Tests provide adequate coverage
  • Code is well-commented
  • New features are translatable or updates will not break translations
  • Relevant documentation has been added or updated
  • User impact is well-understood and desirable
  • Pull Request is labeled appropriately
  • Follow-up work items (including potential tech debt) are tracked and linked

jmkulwik
jmkulwik approved these changes Oct 24, 2019
View reviewed changes
Copy link
Contributor

@jmkulwik jmkulwik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ajpal ajpal merged commit 8af46d8 into staging Oct 24, 2019
@ajpal ajpal deleted the oct24-unique-named-sprites branch October 24, 2019 17:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jmkulwik jmkulwik jmkulwik approved these changes

Assignees
No one assigned
Labels
star-labs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ajpal @jmkulwik