add script to reset race data for a subset of users #31491
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sureshc
reviewed
Oct 25, 2019
|
|
||
| require_relative '../../../dashboard/config/environment' | ||
|
|
||
| File.readlines(ARGV[0]).each do |line| |
There was a problem hiding this comment.
It's probably worth rescuing any error that is raised within this block. Log the id that failed and then move on to the next one.
sureshc
reviewed
Oct 25, 2019
| end | ||
|
|
||
| user.races = nil | ||
| user.save! |
There was a problem hiding this comment.
In addition to rescuing/logging errors, maybe log the id of every User that is successfully saved? That helps track what went right/wrong after the script has been run.
sureshc
approved these changes
Oct 25, 2019
sureshc
reviewed
Oct 25, 2019
| user.save! | ||
| puts("user #{id} - success") | ||
| rescue | ||
| puts("user #{id} - ERROR - other") |
There was a problem hiding this comment.
Doubt there will be any errors persisting the record, but if there are it would be handy to out the error message here.
There was a problem hiding this comment.
My plan is that if there are errors here, to rerun this script over those users with more useful output
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To be used as part of the follow-up to #31282