[student-libraries] Exporter ui fail #31502
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ajpal
reviewed
Oct 29, 2019
| @@ -128,6 +131,7 @@ class LibraryCreationDialog extends React.Component { | |||
| libraryJson, | |||
| error => { | |||
| console.warn(`Error publishing library: ${error}`); | |||
There was a problem hiding this comment.
Still want this console warn now that there's UI for it?
There was a problem hiding this comment.
Jessie and I chatted and we decided yes, because then we can help debug if someone writes in with issues.
ajpal
reviewed
Oct 29, 2019
| <p id="error-alert" style={styles.alert}> | ||
| {i18n.libraryPublishFail()} | ||
| </p> | ||
| <div> |
There was a problem hiding this comment.
Why is this container div needed?
There was a problem hiding this comment.
I liked the idea of having this state-specific behavior in a div, but it's not necessarily needed. I'm going to leave for now to avoid delaying this PR.
ajpal
approved these changes
Oct 29, 2019
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Display an error message and ask users to re-try when publish fails.
Testing story
Added new tests to cover when this is expected and not expected
Reviewer Checklist: