Fix ArgumentError in VolunteerEngineerSubmission2015 #31583
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I forgot that this parameter would be a string. Casting it with `to_i` to resolve. I've also updated the test to catch this scenario. I started working on the Volunteer map in #31493 This regression was introduced in #31541 Honeybadger error: https://app.honeybadger.io/projects/34365/faults/56475122 Slack conversation: https://codedotorg.slack.com/archives/C55JZ1BPZ/p1572393884034500 This small fix for the ArgumentError probably does not fix a more general issue with the performance of the volunteer map query, which may require we rethink the behavior of this page.
joshlory
approved these changes
Oct 30, 2019
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I forgot that this parameter would be a string. Casting it with
to_ito resolve. I've also updated the test to catch this scenario.This small fix for the ArgumentError probably does not fix a more general issue with the performance of the volunteer map query, which may require we rethink the behavior of this page.
Reviewer Checklist: