[student-libraries] Multiple single-line comments in a row are now parsed as a multiline comment. #31605
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ajpal
reviewed
Oct 31, 2019
| .substr(1) | ||
| .split('\n * ') | ||
| .join('\n'); | ||
| // let commentText = comment ? comment.text : ''; |
There was a problem hiding this comment.
nit: remove commented out line
ajpal
approved these changes
Nov 1, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Since we couldn't make a multiline comment block, we instead decided to support multiple single-line comment blocks as if they were a multiline comment block.
That means these two will be interpreted the same way from a library's perspective.
Links
Testing story
Reviewer Checklist: