Add debug logic to Contact Rollups db result set stream iterator #31660
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hacodeorg
reviewed
Nov 4, 2019
| @@ -301,6 +301,10 @@ def self.sync_contact_rollups_to_main(log_collector) | |||
|
|
|||
| log("#{Time.now} Completed. #{num_total} source rows processed. #{num_inserts} insert(s), #{num_updates} update(s), #{num_unchanged} unchanged.") | |||
| log_collector.info("#{num_total} source rows processed. #{num_inserts} insert(s), #{num_updates} update(s), #{num_unchanged} unchanged.") | |||
| rescue StandardError => error | |||
There was a problem hiding this comment.
You can use the log_collector here to capture the error right when it happens. By doing that we won't have to manually run the script later hopefully it will fail at the same step.
In addition, this will swallow the iteration error and the rest of the script will keep going without knowing there is a failure in the previous step. Should we re-raise here and stop processing?
There was a problem hiding this comment.
I've fixed the swallowing of the error. That was not my intention.
…". Will move it to its own PR. This reverts commit 1ce7ba9.
|
Should we merge this PR? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.