DOTD: adjust DTS time to account for daylight savings time #31669
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Erin007
commented
Nov 4, 2019
| @@ -55,7 +55,7 @@ | |||
| cronjob at:'*/2 * * * *', do:pegasus_dir('sites','virtual','collate_pdfs') | |||
| cronjob at:'30 16,17 * * *', do:deploy_dir('bin', 'cron', 'update_dotd') | |||
| cronjob at:'0 * * * *', do:deploy_dir('bin', 'cron', 'start_broken_link_checker'), notify:'dev+crontab@code.org' | |||
| cronjob at:'0 19 * * 1-5', do:deploy_dir('bin', 'cron', 'commit_content') | |||
| cronjob at:'0 20 * * 1-5', do:deploy_dir('bin', 'cron', 'commit_content') | |||
There was a problem hiding this comment.
Is this the right spot? I don't know how to test besides merge and see what happens....
There was a problem hiding this comment.
thanks for tackling this Erin! It does look like this is one line that needs to be updated, but I would suggest looking at the last time this line was modified to see if you can find all of the lines that need to be updated. things this should include:
- staging noon commit (this line)
- levelbuilder noon commit
- 12:05pm DTS
- levelbuilder 3:something commit
- 3:something DTL
I am not sure if there are others.
davidsbailey
approved these changes
Nov 4, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The content scoop of Levelbuilder content into Staging should happen at noon.
Today, due to daylight savings time, this occurred and hour early at 11am:
I adjusted the cronjob to rectify the timing.