Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update ml-activities to 0.0.9, use initAll() only #31673

Merged
merged 1 commit into from
Nov 4, 2019
Merged

update ml-activities to 0.0.9, use initAll() only #31673

merged 1 commit into from
Nov 4, 2019

Conversation

cpirich
Copy link
Contributor

@cpirich cpirich commented Nov 4, 2019

Description

  • Simplify how we init ml-activities by using a new initAll() export, which requires that we update to ml-activities version 0.0.9

Reviewer Checklist:

  • Tests provide adequate coverage
  • Code is well-commented
  • New features are translatable or updates will not break translations
  • Relevant documentation has been added or updated
  • User impact is well-understood and desirable
  • Pull Request is labeled appropriately
  • Follow-up work items (including potential tech debt) are tracked and linked

breville
breville approved these changes Nov 4, 2019
View reviewed changes
Copy link
Member

@breville breville left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fantastic!

maddiedierker
maddiedierker approved these changes Nov 4, 2019
View reviewed changes
Copy link
Contributor

@maddiedierker maddiedierker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉 yay, thank you for this!

@breville breville merged commit bba2728 into staging Nov 4, 2019
@breville breville deleted the cpirich/update-ml-activities-and-use-initAll branch November 4, 2019 21:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@breville breville breville approved these changes

@maddiedierker maddiedierker maddiedierker approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@cpirich @breville @maddiedierker