Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Play correct submit sound for submitted levels with no log conditions #31685

Merged
merged 2 commits into from Nov 6, 2019
Merged

Play correct submit sound for submitted levels with no log conditions #31685

merged 2 commits into from Nov 6, 2019

Conversation

clareconstantine
Copy link

Description

For submittable levels that don't have log conditions, we were playing the 'failure' sound when we should play the 'win' sound, because we weren't setting the testResults for these levels. This handles this case.

Links

Testing story

Reviewer Checklist:

  • Tests provide adequate coverage
  • Code is well-commented
  • New features are translatable or updates will not break translations
  • Relevant documentation has been added or updated
  • User impact is well-understood and desirable
  • Pull Request is labeled appropriately
  • Follow-up work items (including potential tech debt) are tracked and linked

@clareconstantine clareconstantine changed the title handle submitted levels with no log conditions Play correct submit sound for submitted levels with no log conditions Nov 5, 2019
Erin007
Erin007 approved these changes Nov 6, 2019
View reviewed changes
Copy link
Contributor

@Erin007 Erin007 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tada! This is kind of an obscure part of the codebase even veteran LP'ers don't touch often and you crushed it. Well done, Clare!

@clareconstantine clareconstantine merged commit ab5b3e7 into staging Nov 6, 2019
@clareconstantine clareconstantine deleted the sad-bee branch November 6, 2019 21:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidsbailey davidsbailey davidsbailey approved these changes

@Erin007 Erin007 Erin007 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@clareconstantine @davidsbailey @Erin007